Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate and remove aws-node-termination-handler chart in favor of upstream chart #1155

Merged

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Sep 24, 2024

Issue

Description of changes

  • Deprecate and remove aws-node-termination-handler chart in favor of upstream chart which is being published directly to Public ECR

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bryantbiggs
Copy link
Member Author

cc @aws/ec2-guacamole

@bryantbiggs bryantbiggs force-pushed the chore/deprecate-node-termination-handler branch from 3efc97a to 45523e6 Compare October 2, 2024 20:45
@bryantbiggs bryantbiggs force-pushed the chore/deprecate-node-termination-handler branch from 45523e6 to 347af62 Compare October 2, 2024 21:01
@LikithaVemulapalli
Copy link

Hello @bryantbiggs, yes you can go ahead and remove NTH helm charts from eks-charts, we updated our docs to retrieve the charts from ECR-Public. Thanks :)

@bryantbiggs bryantbiggs merged commit 0b3680f into aws:master Oct 3, 2024
1 check passed
@bryantbiggs bryantbiggs deleted the chore/deprecate-node-termination-handler branch October 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment